Add min support to exponential histograms #133639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
v9.2.0
external-contributor
JonasKunz
added
>non-issue
:StorageEngine/Mapping
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
felixbarny
approved these changes
Aug 28, 2025
kkrik-es
reviewed
Aug 28, 2025
...ram/src/test/java/org/elasticsearch/exponentialhistogram/ExponentialHistogramUtilsTests.java
Show resolved
Hide resolved
kkrik-es
reviewed
Aug 28, 2025
| histo.tryAddBucket(2, 6, false); | ||
| assertThat(toJson(histo), equalTo("{\"scale\":5,\"sum\":1.1,\"negative\":{\"indices\":[-1,2],\"counts\":[4,6]}}")); | ||
| assertThat(toJson(histo), equalTo("{\"scale\":5,\"sum\":1.1,\"min\":-0.5,\"negative\":{\"indices\":[-1,2],\"counts\":[4,6]}}")); | ||
| } |
There was a problem hiding this comment.
Do we have an example here where sum and min are calculated from the histogram buckets?
There was a problem hiding this comment.
No, this tests are only about serialization and don't care about semantic correctness.
For the correctness of aggregates we have tests in ExponentialHistogramMergerTests.java.
kkrik-es
reviewed
Aug 28, 2025
| valueCount = valueCounts.longValue(); | ||
| valueSum = NumericUtils.sortableLongToDouble(valueSums.longValue()); | ||
|
|
||
| if (valueMins != null && valueMins.advanceExact(docId)) { |
There was a problem hiding this comment.
Can we have sum but not min?
There was a problem hiding this comment.
Yes, for empty histograms: sum is 0.0, but min is not available.
kkrik-es
approved these changes
Aug 28, 2025
JeremyDahlgren
pushed a commit
to JeremyDahlgren/elasticsearch
that referenced
this pull request
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very similar to #133381 , but adds support for tracking the exact minimum for exponential histograms:
null